Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 04a6738

Browse filesBrowse files
zou3519zou3519
committed
Update on "[Inductor] short-term fix for needs_fixed_stride_order silent incorrectness"
This is a low-risk short-term fix for #128084, for the purposes of 2.4.1. The actual fix for that issue is more risky and we'll target 2.5. needs_fixed_stride_order is silently incorrect with args that are mutable because it creates clones of those args, writes into them, and doesn't update the original args. This PR makes it so that needs_fixed_stride_order doesn't apply to inputs that are being mutated. This PR doesn't completely fix the problem, but it makes it less incorrect: most of the time the input already has the correct strides but inductor fails to recognize it, and in those cases writing directly to the input is fine. Test Plan: - new test [ghstack-poisoned]
1 parent adbbd08 commit 04a6738
Copy full SHA for 04a6738

File tree

Expand file treeCollapse file tree

0 file changed

+0
-0
lines changed
Filter options
    Expand file treeCollapse file tree

    0 file changed

    +0
    -0
    lines changed

    0 commit comments

    Comments
    0 (0)
    Morty Proxy This is a proxified and sanitized view of the page, visit original site.