Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion 6 src/runtime/StateSerialization/NoopFormatter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
namespace Python.Runtime;

public class NoopFormatter : IFormatter {
public object Deserialize(Stream s) => throw new NotImplementedException();

public object Deserialize(Stream s) => throw new NotImplementedException(
"Cannot deserialize using 'NoopFormatter', implement 'Python.Runtime.RuntimeData.FormatterType' if needed"
);

public void Serialize(Stream s, object o) {}

public SerializationBinder? Binder { get; set; }
Expand Down
27 changes: 26 additions & 1 deletion 27 src/runtime/StateSerialization/RuntimeData.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,41 @@ namespace Python.Runtime
{
public static class RuntimeData
{
//TODO: put it in a utility class instead of inside the RuntimeData Class.
private static Version? GetNetVersion(string verToCheck)
{
// Examples:
// ".NET 8.0.0"
// ".NET 9.0.0"
// ".NET Framework 4.8.1"
// ".NET Core 3.1.32"
string desc = RuntimeInformation.FrameworkDescription;
if (desc.StartsWith(verToCheck, StringComparison.OrdinalIgnoreCase))
{
var verStr = desc.Split(' ').Last();
if (Version.TryParse(verStr, out var ver))
return ver;
}
return null;
}

public readonly static Func<IFormatter> DefaultFormatterFactory = () =>
{
try
//The issue here is that just instancing BynaryFormatter doesn't solve the problem.
//you need to use it to generate the exception.
/*try
{
return new BinaryFormatter();
}
catch
{
return new NoopFormatter();
}*/
var ver = GetNetVersion(".NET");
if(ver != null && ver.Major >= 9) {
return new NoopFormatter();
} else {
return new BinaryFormatter();
}
};

Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.