Prevent crash during debugging when attempting to inspect PyObject #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
When debugging code, that uses
PyObjectinstances, debugger would try to executePyObject.ToStringto showPyObjectvalues in watches window. That call causesAccessViolationExceptionwhen the current thread does not hold global interpreter lock.This change adds
DebuggerDisplayattribute toPyObject, that makes debugger first check if GIL is held by the current thread, and only useToStringwhen it does. Otherwise, a message with object handle and a suggestion to acquire GIL is displayed.