fix: avoid loading adapter list twice #1564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1564 will not alter performanceComparing Summary
|
028d1c3 to
0488d34
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1564 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 33 33
Lines 3393 3401 +8
Branches 463 463
=======================================
+ Hits 3386 3394 +8
Misses 5 5
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdraco
reviewed
Apr 10, 2025
0488d34 to
cc4b790
Compare
cc4b790 to
d236934
Compare
d236934 to
62482d9
Compare
Load adapter list only once if operating in dual-stack mode. Also fix typing around adapater list to match what ifaddr defines.
1ae0455 to
3b3887f
Compare
bdraco
approved these changes
Apr 14, 2025
|
Should be good to go once the CI is green |
bdraco
reviewed
Apr 14, 2025
bdraco
reviewed
Apr 14, 2025
18f6091 to
a478d24
Compare
|
Only the PR title matters for the the commit messages check since its going to get squashed anyways |
bff2495 to
d5a3466
Compare
Ah whoops, yeah well it's fixed now 😅 Sorry for the churn, was a bit distracted here 🙈 |
bdraco
reviewed
Apr 14, 2025
Officially deprecate get_all_addresses and get_all_addresses_v6 in favor of using ifaddr directly.
d5a3466 to
e64d166
Compare
bdraco
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load adapter list only once if operating in dual-stack mode. Also fix typing around adapater list to match what ifaddr defines.