feat: enable building of arm64 macOS builds #1384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issues #1376 and #1380.
Enabling building for macOS arm64 builds is simple, because the newest macOS runners build in arm64 by default. Hence the addition of
macos-latest
to the matrix.Also, since macos-11 runners are deprecated (see [1]), switched to macos-12 for the x86_64 builds.
Incidentally, it seems current Ubuntu runners don't include
apt-get
by default, so switched to usingapt
command.So to summarize:
macos-12
runners will continue building macOS x86_64 buildsmacos-latest
runners will now build macOS arm64 buildsThe new files look like this:
Note that it seems impossible to build cp38 for arm64 so excluded that configuration, while pp38 seems fine.
Unrelated, but it seem all wheels after cp39 include .c source code in them, making the wheels larger. This should probably addressed in a separate PR.
[1] https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/