Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix flake8 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2018
Merged

Fix flake8 #131

merged 3 commits into from
Jun 7, 2018

Conversation

mdiez-modus
Copy link

This makes flake8 happy so the build can pass again.

The reason I added flake8 --version to the tests is because my version of flake8 expects the imports in a different order.
This way I could install the same version as you and therefore make sure everything passes.

pep8-naming in particular is crashing on version 0.6.0 so I had to black list it.
That's a trick I learned from the author of catt

@coveralls
Copy link

coveralls commented May 8, 2018

Coverage Status

Coverage remained the same at 94.072% when pulling a0a0295 on marcosdiez:fix_flake8 into 826c961 on jstasiak:master.

@mdiez-modus
Copy link
Author

@jstasiak please don't forget about me!

@jstasiak jstasiak merged commit 53bc65a into python-zeroconf:master Jun 7, 2018
@jstasiak
Copy link
Collaborator

jstasiak commented Jun 7, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.