feat: improve performance of ServiceBrowser outgoing query scheduler #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #821 The bulk of the time was spent checking to see if queries were ready to go out from the reschedule which checks every type the ServiceBrowser has configured. Since we are only adjusting one type we can guard this with a simple check to avoid checking every type
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1170 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 22 22
Lines 2671 2673 +2
Branches 464 465 +1
=======================================
+ Hits 2666 2668 +2
Misses 3 3
Partials 2 2
☔ View full report in Codecov by Sentry. |
bdraco
commented
May 4, 2023
|
Looks like we already have good coverage to make sure the query schedule will always return 0 if it should send now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of the time was spent checking to see if queries were ready to go out from the reschedule which checks every type the ServiceBrowser has configured. Since we are only adjusting one type we can guard this with a simple check to avoid checking every type