From bd643a227bc4d6a949d558850ad1431bc2940d74 Mon Sep 17 00:00:00 2001
From: Stefan Agner <stefan@agner.ch>
Date: Wed, 2 Apr 2025 19:41:16 +0200
Subject: [PATCH 1/2] fix: correctly override question type flag for requests
 (#1558)

* fix: correctly override question type flag for requests

Currently even when setting the explicit question type flag, the
implementation ignores it for subsequent queries. This commit ensures
that all queries respect the explicit question type flag.

* chore(tests): add test for explicit question type flag

Add unit test to validate that the explicit question type flag is set
correctly in outgoing requests.
---
 src/zeroconf/_services/info.py |  2 +-
 tests/services/test_info.py    | 21 +++++++++++++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/src/zeroconf/_services/info.py b/src/zeroconf/_services/info.py
index 9cd8df16..fff9e125 100644
--- a/src/zeroconf/_services/info.py
+++ b/src/zeroconf/_services/info.py
@@ -859,7 +859,7 @@ async def async_request(
                 if last <= now:
                     return False
                 if next_ <= now:
-                    this_question_type = question_type or QU_QUESTION if first_request else QM_QUESTION
+                    this_question_type = question_type or (QU_QUESTION if first_request else QM_QUESTION)
                     out = self._generate_request_query(zc, now, this_question_type)
                     first_request = False
                     if out.questions:
diff --git a/tests/services/test_info.py b/tests/services/test_info.py
index 3d4c5302..660b56d2 100644
--- a/tests/services/test_info.py
+++ b/tests/services/test_info.py
@@ -17,6 +17,7 @@
 
 import zeroconf as r
 from zeroconf import DNSAddress, RecordUpdate, const
+from zeroconf._protocol.outgoing import DNSOutgoing
 from zeroconf._services import info
 from zeroconf._services.info import ServiceInfo
 from zeroconf._utils.net import IPVersion
@@ -1871,3 +1872,23 @@ async def test_address_resolver_ipv6():
     aiozc.zeroconf.async_send(outgoing)
     assert await resolve_task
     assert resolver.ip_addresses_by_version(IPVersion.All) == [ip_address("fe80::52e:c2f2:bc5f:e9c6")]
+
+
+@pytest.mark.asyncio
+async def test_unicast_flag_if_requested() -> None:
+    """Verify we try four times even with the random delay."""
+    type_ = "_typethatisnothere._tcp.local."
+    aiozc = AsyncZeroconf(interfaces=["127.0.0.1"])
+
+    def async_send(out: DNSOutgoing, addr: str | None = None, port: int = const._MDNS_PORT) -> None:
+        """Sends an outgoing packet."""
+        for question in out.questions:
+            assert question.unicast
+
+    # patch the zeroconf send
+    with patch.object(aiozc.zeroconf, "async_send", async_send):
+        await aiozc.async_get_service_info(
+            f"willnotbefound.{type_}", type_, question_type=r.DNSQuestionType.QU
+        )
+
+    await aiozc.async_close()

From 16c257c0ca2772a024c6e9920df2375436bfc73c Mon Sep 17 00:00:00 2001
From: semantic-release <semantic-release>
Date: Wed, 2 Apr 2025 17:51:12 +0000
Subject: [PATCH 2/2] 0.146.3

Automatically generated by python-semantic-release
---
 CHANGELOG.md             | 19 +++++++++++++++++++
 pyproject.toml           |  2 +-
 src/zeroconf/__init__.py |  2 +-
 3 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0ffa0f63..ccb6bdd7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,25 @@
 # CHANGELOG
 
 
+## v0.146.3 (2025-04-02)
+
+### Bug Fixes
+
+- Correctly override question type flag for requests
+  ([#1558](https://github.com/python-zeroconf/python-zeroconf/pull/1558),
+  [`bd643a2`](https://github.com/python-zeroconf/python-zeroconf/commit/bd643a227bc4d6a949d558850ad1431bc2940d74))
+
+* fix: correctly override question type flag for requests
+
+Currently even when setting the explicit question type flag, the implementation ignores it for
+  subsequent queries. This commit ensures that all queries respect the explicit question type flag.
+
+* chore(tests): add test for explicit question type flag
+
+Add unit test to validate that the explicit question type flag is set correctly in outgoing
+  requests.
+
+
 ## v0.146.2 (2025-04-01)
 
 ### Bug Fixes
diff --git a/pyproject.toml b/pyproject.toml
index b2850113..7e21a38f 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "zeroconf"
-version = "0.146.2"
+version = "0.146.3"
 description = "A pure python implementation of multicast DNS service discovery"
 authors = ["Paul Scott-Murphy", "William McBrine", "Jakub Stasiak", "J. Nick Koston"]
 license = "LGPL-2.1-or-later"
diff --git a/src/zeroconf/__init__.py b/src/zeroconf/__init__.py
index 01496e22..c266c318 100644
--- a/src/zeroconf/__init__.py
+++ b/src/zeroconf/__init__.py
@@ -88,7 +88,7 @@
 
 __author__ = "Paul Scott-Murphy, William McBrine"
 __maintainer__ = "Jakub Stasiak <jakub@stasiak.at>"
-__version__ = "0.146.2"
+__version__ = "0.146.3"
 __license__ = "LGPL"