Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add support for vcs root directory being a parent of module build root.#59

Closed
mklein0 wants to merge 4 commits intopython-versioneer:masterpython-versioneer/python-versioneer:masterfrom
mklein0:vcs_rootmklein0/python-versioneer:vcs_rootCopy head branch name to clipboard
Closed

Add support for vcs root directory being a parent of module build root.#59
mklein0 wants to merge 4 commits intopython-versioneer:masterpython-versioneer/python-versioneer:masterfrom
mklein0:vcs_rootmklein0/python-versioneer:vcs_rootCopy head branch name to clipboard

Conversation

@mklein0
Copy link

@mklein0 mklein0 commented Dec 18, 2014

No description provided.

@mklein0
Copy link
Author

mklein0 commented Dec 18, 2014

This is a patch for issue#38.

@mklein0 mklein0 changed the title Add support for vcs root directories different from module src root. Add support for vcs root directory being a parent of module build root. Feb 17, 2016
@mklein0
Copy link
Author

mklein0 commented Mar 27, 2016

I have an alternate implementation of this fix which relies on implicitly deriving the GIT root via the git rev-parse --show-toplevel command. This is located on an alternate branch, mklein0/python-versioneer@4bc41f8

@warner
Copy link
Collaborator

warner commented Apr 12, 2016

I think this is mostly subsumed by #61, which I've been hacking on the last few days (and which is slightly smaller because I think we don't really need to know exactly where the .git directory is: except possibly for installation, Versioneer's git commands can be run from anywhere under the source tree). But I'm adding this to the 0.17 milestone so I don't forget to incorporate the test-coverage and -w wheelhouse fixes from this branch.

@warner warner added this to the 0.17 milestone Apr 12, 2016
@warner
Copy link
Collaborator

warner commented Apr 13, 2016

Ok, it looks like all the tests from this branch are included in the other one. Closing this in favor of #61.

@warner warner closed this Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.