hide console window if pythonw.exe is used#285
Merged
effigies merged 1 commit intopython-versioneer:masterpython-versioneer/python-versioneer:masterfrom Feb 20, 2022
CSchulzeTLK:masterCopy head branch name to clipboard
Merged
hide console window if pythonw.exe is used#285effigies merged 1 commit intopython-versioneer:masterpython-versioneer/python-versioneer:masterfrom CSchulzeTLK:masterCopy head branch name to clipboard
effigies merged 1 commit intopython-versioneer:masterpython-versioneer/python-versioneer:masterfrom
CSchulzeTLK:masterCopy head branch name to clipboard
Conversation
Contributor
|
Should be able to fix the tests by merging/rebasing master. Though might be worth waiting on #283 (or rebasing on that) to get Windows tests too. |
Contributor
Author
|
Yes, I'm still using 0.20 due to 283, and couldn't benefit from the changes of this pull request. |
Contributor
|
#283 is merged. Could you merge/rebase |
improve comment
Contributor
|
Tests passing. Looks great. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve the isse #284