Support regex patten to search for tags#186
Open
wsalmonct wants to merge 1 commit intopython-versioneer:masterpython-versioneer/python-versioneer:masterfrom
wsalmonct:feature/regexTagswsalmonct/python-versioneer:feature/regexTagsCopy head branch name to clipboard
Open
Support regex patten to search for tags#186wsalmonct wants to merge 1 commit intopython-versioneer:masterpython-versioneer/python-versioneer:masterfrom wsalmonct:feature/regexTagswsalmonct/python-versioneer:feature/regexTagsCopy head branch name to clipboard
wsalmonct wants to merge 1 commit intopython-versioneer:masterpython-versioneer/python-versioneer:masterfrom
wsalmonct:feature/regexTagswsalmonct/python-versioneer:feature/regexTagsCopy head branch name to clipboard
Conversation
7d7ebd4 to
ffea176
Compare
Contributor
|
Can you merge/rebase |
gtristan
pushed a commit
to buildstream-migration/buildstream
that referenced
this pull request
Oct 9, 2020
This has been done in a way that I hope might be able to be upstreamed in to versioneer. This is not garanteed but it would be good if it could be. Please see python-versioneer/python-versioneer#186 and https://github.com/wsalmonct/python-versioneer/tree/feature/regexTags for further details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to be able to use regex to search for version tags that don't have a nice prefix.
I was going to use prefix but while the git describe finds the tag you then test if the start of the string is equal to the prefix in a non regex way, so I guessed this would let me search while not braking your current behaviour.
Is this something you would consider merging?