API 9.3 Topics in private chats #5079
Open
+414
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check-list for PRs
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSIONor ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst(optional)__all__sIf the PR contains API changes (otherwise, you can ignore this passage)Checked the Bot API specific sections of the Stability Policy
Created a PR to remove functionality deprecated in the previous Bot API release (see here)
New Classesself._id_attrsand corresponding documentation__init__acceptsapi_kwargsas keyword-onlyAdded New Shortcuts
telegram.Chat&telegram.Userfor all methods that acceptchat/user_idtelegram.Messagefor all methods that acceptchat_idandmessage_idFor newtelegram.Messageshortcuts: Addedquoteargument if methods acceptreply_to_message_idIntelegram.CallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf Relevant
telegram.constantsand shortcuts to them as class variablestelegram.Message.effective_attachmenttelegram.ext.ConversationHandler_extbot.pybot_methods.rstREADME.rst(including the badge) andtelegram.constants.BOT_API_VERSION_INFOTopics in private chats
For now testing the new method
send_message_draftis done without request. To test them effectively (with request) we'll have to manually create a topic in one of the test bots as unlike supergroup topics they can not be created programmatic ally.The name for the new Message shortcut
Message.reply_text_draftcan be discussed. I also debated havingreply_{markdown[v2],html}_draftor not. markdown would make sense i guess as llms often output in markdown but then we should have all of them for consistency with reply_{text,..} (?)ps
should be ready for review i just need to give it one myself before requesting to make sure its up to date with latest TG release.