Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add Parameter pattern to JobQueue.jobs() #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Bibo-Joshi merged 6 commits into from
Jan 2, 2025
Merged

Add Parameter pattern to JobQueue.jobs() #4613

Bibo-Joshi merged 6 commits into from
Jan 2, 2025

Conversation

@Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Dec 29, 2024

Closes #4544

@Bibo-Joshi Bibo-Joshi added the 🔌 enhancement pr description: enhancement label Dec 29, 2024
@Bibo-Joshi Bibo-Joshi mentioned this pull request Dec 29, 2024
Closed
@codecov
Copy link

codecov bot commented Dec 29, 2024

❌ 289 Tests Failed:

Tests completed Failed Passed Skipped
6656 289 6367 454
View the top 3 failed tests by shortest run time 
tests.ext.test_applicationbuilder.TestApplicationBuilder::test_mutually_exclusive_for_bot[http_version]
Stack Traces | 0.001s run time 
No failure message available
tests.ext.test_applicationbuilder.TestApplicationBuilder::test_mutually_non_exclusive_for_updater[get_updates_write_timeout1]
Stack Traces | 0.001s run time 
No failure message available
tests.test_forum.TestForumMethodsWithRequest::test_send_message_to_topic
Stack Traces | 0.001s run time 
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

harshil21
harshil21 approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

telegram/ext/_jobqueue.py Outdated Show resolved Hide resolved
telegram/ext/_jobqueue.py Show resolved Hide resolved
@Bibo-Joshi Bibo-Joshi merged commit a781a4f into master Jan 2, 2025
25 of 26 checks passed
@Bibo-Joshi Bibo-Joshi deleted the regex-jobs branch January 2, 2025 09:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@harshil21 harshil21 harshil21 approved these changes

@Poolitzer Poolitzer Awaiting requested review from Poolitzer

Assignees

No one assigned

Labels

🔌 enhancement pr description: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filter jobs with an optional parameter use_regex

3 participants

@Bibo-Joshi @harshil21
Morty Proxy This is a proxified and sanitized view of the page, visit original site.