Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix comparison with subclasses #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix comparison with subclasses #453

merged 1 commit into from
Dec 13, 2024

Conversation

viccie30
Copy link
Contributor

The check in _comparator does not match the check in Version.compare, breaking comparison with subclasses.

@tomschr
Copy link
Member

tomschr commented Dec 13, 2024

Thanks a lot @viccie30, good catch! 👍

@tomschr tomschr merged commit 15aa6a6 into python-semver:master Dec 13, 2024
18 checks passed
@viccie30 viccie30 deleted the fix-subclass-comparison branch December 13, 2024 09:03
@tomschr tomschr mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viccie30 @tomschr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.