Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add Version class to __all__ export. Fix #410 #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

Soneji
Copy link
Contributor

@Soneji Soneji commented Jun 14, 2023

No description provided.

Copy link
Member

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Soneji for your contribution! 👍 I have a minor comment, see below.

To avoid formatting errors, call tox -e checks to see if everything is okay. Sometimes black complains about some lines. 😉

src/semver/__init__.py Outdated Show resolved Hide resolved
@Soneji
Copy link
Contributor Author

Soneji commented Jun 14, 2023

Looks like the checks have passed. Is this ok to merge?

@tomschr
Copy link
Member

tomschr commented Jun 14, 2023

Many thanks for the contribution! 👍

Looks like the checks have passed. Is this ok to merge?

Yes, I can merge it.

@tomschr tomschr merged commit 17bc257 into python-semver:master Jun 14, 2023
@Soneji
Copy link
Contributor Author

Soneji commented Jun 14, 2023

Amazing, thank you so much

Are you able to release and publish a patch for this?

Rocking that contributor badge now 😎

@tomschr
Copy link
Member

tomschr commented Jun 14, 2023

Amazing, thank you so much

Thanks for your contribution! ❤️

Are you able to release and publish a patch for this?

Yes, I'm actually planning to create a new release. Not sure if I have time today, but it will be available very soon. I'll let you know. 🙂

@tomschr
Copy link
Member

tomschr commented Jun 14, 2023

@Soneji I was able to create it sooner than I thought. 😉 Find all information here (including PyPI):

https://github.com/python-semver/python-semver/releases/tag/3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.