Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix return type of classmethod parse #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Fix return type of classmethod parse #396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35d3f9a
Fix return type of classmethod parse
def- Feb 27, 2023
38bc78f
Move T definition some lines up
tomschr Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions 8 src/semver/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
cast,
Callable,
Collection,
Type,
TypeVar,
)

from ._types import (
Expand All @@ -28,6 +30,8 @@
Comparable = Union["Version", Dict[str, VersionPart], Collection[VersionPart], str]
Comparator = Callable[["Version", Comparable], bool]

T = TypeVar("T", bound="Version")


def _comparator(operator: Comparator) -> Comparator:
"""Wrap a Version binary op method in a type-check."""
Expand Down Expand Up @@ -571,8 +575,8 @@ def match(self, match_expr: str) -> bool:

@classmethod
def parse(
cls, version: String, optional_minor_and_patch: bool = False
) -> "Version":
cls: Type[T], version: String, optional_minor_and_patch: bool = False
) -> T:
"""
Parse version string to a Version instance.

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.