Fix: All python -m semver commands fail with 'error: invalid choice:'
#393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by __main__.py passing `sys.argv` to `cli.main()`, which includes the path of the script in `sys.argv[0]`. `argparse.ArgumentParser.parse_args()` parses this as the subcommand name, causing it to throw an error.
|
Thanks @zanecodes! This is great! 👍 You are right, this should be fixed.
Good question. I've looked in the file |
|
Hi @zanecodes, |
tomschr
added a commit
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by __main__.py passing
sys.argvtocli.main(), which includes the path of the script insys.argv[0].argparse.ArgumentParser.parse_args()parses this as the subcommand name, causing it to throw an error.This could also be fixed by removing
sys.argventirely from the arguments passed tocli.main(), asargparse.ArgumentParser.parse_args()will usesys.argv[1:]by default.I'm not sure if this change warrants an added test, as the existing tests cover
cli.main()directly, but such a test would be reasonably straightforward to create and I can do so if you like.