Fix pydantic/semver example #392

mssalvatore · Jan 31, 2023

The current example, when used with semver 3.0.0.dev4 and pydantic 1.10.4, produces the following error:

Traceback (most recent call last):
  File "/home/msalvatore/compost/semver_test/test.py", line 19, in <module>
    class MyModel(pydantic.BaseModel):
  File "pydantic/main.py", line 198, in pydantic.main.ModelMetaclass.__new__
  File "pydantic/fields.py", line 506, in pydantic.fields.ModelField.infer
  File "pydantic/fields.py", line 436, in pydantic.fields.ModelField.__init__
  File "pydantic/fields.py", line 557, in pydantic.fields.ModelField.prepare
  File "pydantic/fields.py", line 834, in pydantic.fields.ModelField.populate_validators
  File "pydantic/class_validators.py", line 263, in pydantic.class_validators.prep_validators
  File "pydantic/class_validators.py", line 259, in pydantic.class_validators.make_generic_validator
  File "pydantic/class_validators.py", line 310, in pydantic.class_validators._generic_validator_basic
pydantic.errors.ConfigError: Invalid signature for validator <bound method Version.parse of <class '__main__.PydanticVersion'>>: (version: Union[str, bytes], optional_minor_and_patch: bool = False) -> 'Version', should be: (value, values, config, field), "values", "config" and "field" are all optional.

This commit fixes the example in the documentation so that it works and does not raise an error.

The current example, when used with semver 3.0.0.dev4 and pydantic 1.10.4, produces the following error: pydantic.errors.ConfigError: Invalid signature for validator <bound method Version.parse of <class '__main__.PydanticVersion'>>: (version: Union[str, bytes], optional_minor_and_patch: bool = False) -> 'Version', should be: (value, values, config, field), "values", "config" and "field" are all optional. This commit fixes the example in the documentation so that it works and does not raise an error.

tomschr · Jan 31, 2023

Thank you very much @mssalvatore, this is great! 👍

mssalvatore force-pushed the fix-pydantic-semver-example branch from cd0f504 to 35da4f6 Compare January 31, 2023 14:06

tomschr merged commit 2018346 into python-semver:master Jan 31, 2023

mssalvatore deleted the fix-pydantic-semver-example branch January 31, 2023 15:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix pydantic/semver example #392

Fix pydantic/semver example #392

mssalvatore commented Jan 31, 2023

tomschr commented Jan 31, 2023

Search code, repositories, users, issues, pull requests...

Fix pydantic/semver example #392

Fix pydantic/semver example #392

Conversation

mssalvatore commented Jan 31, 2023

tomschr commented Jan 31, 2023