Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

tox/pytest: Add testpaths and use importlib #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions 3 changelog.d/388.trivial.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
For pytest, switch to the more modern :mod:`importlib` approach
as it doesn't require to modify :data:`sys.path`:
https://docs.pytest.org/en/7.2.x/explanation/pythonpath.html
4 changes: 2 additions & 2 deletions 4 setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ semver = py.typed
[tool:pytest]
norecursedirs = .git build .env/ env/ .pyenv/ .tmp/ .eggs/ venv/
testpaths = tests docs
# pythonpath = src
pythonpath = src tests
filterwarnings =
ignore:Function 'semver.*:DeprecationWarning
# ' <- This apostroph is just to fix syntax highlighting
addopts =
# --import-mode=importlib
--import-mode=importlib
--no-cov-on-fail
--cov=semver
--cov-report=term-missing
Expand Down
2 changes: 0 additions & 2 deletions 2 tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

import semver

# sys.path.insert(0, "docs/usage")

from coerce import coerce # noqa:E402
from semverwithvprefix import SemVerWithVPrefix # noqa:E402
import packaging.version
Expand Down
1 change: 1 addition & 0 deletions 1 tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ python =
[testenv]
description = Run test suite for {basepython}
allowlist_externals = make
skip_install = true
commands = pytest {posargs:}
deps =
pytest
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.