Fix #291: Disallow negative numbers in VersionInfo #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
439cbbc to
fba756e
Compare
Disallow negative numbers in major, minor, and patch in semver.VersionInfo. Reason: a version can only contain positive numbers
fba756e to
b25aa07
Compare
|
Is it a feature or a semantic bugfix? This kind of feels like bug. I would kind of expect it to reject negative numbers out of the box. |
Closed
tomschr
added a commit
to tomschr/python-semver
that referenced
this pull request
Oct 19, 2020
* python-semver#291/python-semver#292 Disallow negative numbers in VersionInfo
tomschr
added a commit
that referenced
this pull request
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #291 and contains the following change:
Disallow negative numbers of
major,minor, andpatchinsemver.VersionInfo.Reason: a version can only contain positive numbers
@tlaferriere This is the corresponding pull request. Maybe there are better ways to do it. 😉
I would release 2.12.0 if you think this is useful.