Fix #274: String Types Py2 vs. Py3 compatibility #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
282d185 to
9d30056
Compare
eli-darkly
reviewed
Jul 10, 2020
eli-darkly
approved these changes
Jul 10, 2020
9d30056 to
979b3d5
Compare
979b3d5 to
19f4e18
Compare
|
@eli-darkly Eli, sorry for the long delay. I've added you as a contributor and documented this in our documentation. If you would like to have a final look I can merge and create a new release. |
eli-darkly
approved these changes
Oct 16, 2020
2d1c4b0 to
79f901a
Compare
This fixes problems between different string types. In Python2 str vs. unicode and in Python3 str vs. bytes. * Add some code from six project * Suppress two flake8 issues (false positives) * Update Changelog * Update CONTRIBUTORS * Document creating a version from a byte string Co-authored-by: Eli Bishop <eli-darkly@users.noreply.github.com>
79f901a to
00fb7c4
Compare
tomschr
added a commit
to tomschr/python-semver
that referenced
this pull request
Oct 17, 2020
* python-semver#274 / python-semver#275 String Types Py2 vs. Py3 compatibility * python-semver#277 Turn VersionInfo.parse into classmethod to allow subclasses * python-semver#286 Add author and update changelog for python-semver#276/python-semver#277
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #274 and contains:
fixes problems between different string types. In Python2
strvs.unicodeand in Python3strvs.bytes.@eli-darkly I've tried to recycle some code from the six project. Maybe there is an easier way, maybe we can improve some ugly code. Would you like to have a look at? Thank you! ❤️