Implement __getitem__ for #138 #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add __getitem__ to VersionInfo class * Add test cases * Add user documentation * Extend CHANGELOG Co-authored-by: Thomas Laferriere <tlaferriere@users.noreply.github.com> Co-authored-by: Peter Bittner <bittner@users.noreply.github.com> Co-authored-by: Karol Werner <ppkt@users.noreply.github.com> Co-authored-by: Sébastien Celles <scls19fr@users.noreply.github.com>
s-celles
approved these changes
Apr 26, 2020
|
As nobody seem to object, I'd merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fresh implementation of #138 and contains:
__getitem__toVersionInfoclass@tlaferriere, @bittner: As pr #138 was a bit older and a lot of things have changed now, I've created a fresh new branch so we won't get any conflicts. On top of that, I've added the implementation. If you would like to have a look, that would be great. 👍