Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refactor(parser): ensure commit messages are converted to strings properly #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025
Merged

refactor(parser): ensure commit messages are converted to strings properly #1163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions 9 src/semantic_release/commit_parser/token.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from typing import TYPE_CHECKING, NamedTuple, NoReturn, TypeVar, Union

from semantic_release.commit_parser.util import force_str
from semantic_release.errors import CommitParseError

if TYPE_CHECKING: # pragma: no cover
Expand Down Expand Up @@ -109,9 +110,7 @@ def message(self) -> str:

If the message is of type ``bytes`` then it will be decoded to a ``UTF-8`` string.
"""
m = self.commit.message
message_str = m.decode("utf-8") if isinstance(m, bytes) else m
return message_str.replace("\r", "")
return force_str(self.commit.message).replace("\r", "")

@property
def hexsha(self) -> str:
Expand Down Expand Up @@ -170,9 +169,7 @@ def message(self) -> str:

If the message is of type ``bytes`` then it will be decoded to a ``UTF-8`` string.
"""
m = self.commit.message
message_str = m.decode("utf-8") if isinstance(m, bytes) else m
return message_str.replace("\r", "")
return force_str(self.commit.message).replace("\r", "")

@property
def hexsha(self) -> str:
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.