Ci/fix docs version reference updater #1141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5861a27 to
e854161
Compare
e854161 to
b2dd1ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rationale
When I moved around the CI workflow to make sure we were testing the exact artifact that we were releasing it moved the build step forward in the workflow and removed it from the end. Because of this, the documentation update was no longer being executed during the release so the documentation was not getting updated. This PR, after #1140, makes the automated documentation update work again.
How did you test?
I ran a fake release on my own fork off of master to ensure that the release included the doc updates. It worked. Unfortunately it takes a little longer because we have to run PSR twice now, but hopefully in the future when we have caching this will be sped up on the second run.
How to Verify