Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Rename DbusSomething* and *Binded types #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igo95862 merged 2 commits into from
Dec 14, 2024
Merged

Rename DbusSomething* and *Binded types #83

igo95862 merged 2 commits into from
Dec 14, 2024

Conversation

@dragomirecky
Copy link
Contributor

@dragomirecky dragomirecky commented Dec 9, 2024

Previously part of #82

@igo95862
Copy link
Collaborator

igo95862 commented Dec 11, 2024

Hello @dragomirecky

Sorry I only now found time to review this.

It looks like the imports are not sorted properly:

Fixing /home/igo95862/Projects/python-sdbus-root/python-sdbus/src/sdbus/dbus_proxy_sync_interface_base.py
Fixing /home/igo95862/Projects/python-sdbus-root/python-sdbus/src/sdbus/dbus_proxy_sync_property.py
Fixing /home/igo95862/Projects/python-sdbus-root/python-sdbus/src/sdbus/dbus_proxy_async_interface_base.py
Fixing /home/igo95862/Projects/python-sdbus-root/python-sdbus/src/sdbus/dbus_proxy_async_method.py
Fixing /home/igo95862/Projects/python-sdbus-root/python-sdbus/src/sdbus/dbus_proxy_async_property.py
Fixing /home/igo95862/Projects/python-sdbus-root/python-sdbus/src/sdbus/dbus_proxy_async_signal.py
Fixing /home/igo95862/Projects/python-sdbus-root/python-sdbus/src/sdbus/dbus_proxy_sync_method.py
Fixing /home/igo95862/Projects/python-sdbus-root/python-sdbus/src/sdbus/unittest.py

You can run the auto formatter using ninja -C build/ format-python. (assuming you first setup meson build directory meson setup build) I plan on adding the formatting CI soon.

@dragomirecky
Copy link
Contributor Author

dragomirecky commented Dec 13, 2024

Should be fixed 👍

@igo95862 igo95862 merged commit d958754 into python-sdbus:master Dec 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dragomirecky @igo95862
Morty Proxy This is a proxified and sanitized view of the page, visit original site.