Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add Fan interface for devices#869

Closed
sdb9696 wants to merge 5 commits into
python-kasa:masterpython-kasa/python-kasa:masterfrom
sdb9696:add_fan_interfacesdb9696/python-kasa:add_fan_interfaceCopy head branch name to clipboard
Closed

Add Fan interface for devices#869
sdb9696 wants to merge 5 commits into
python-kasa:masterpython-kasa/python-kasa:masterfrom
sdb9696:add_fan_interfacesdb9696/python-kasa:add_fan_interfaceCopy head branch name to clipboard

Conversation

@sdb9696

@sdb9696 sdb9696 commented Apr 25, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@rytilahti rytilahti added the enhancement New feature or request label Apr 25, 2024
@codecov

codecov Bot commented Apr 26, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 89.24%. Comparing base (724dad0) to head (d291326).
Report is 2 commits behind head on master.

Files Patch % Lines
kasa/smart/smartdevice.py 71.42% 4 Missing and 4 partials ⚠️
kasa/smart/modules/fanmodule.py 68.75% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
- Coverage   89.38%   89.24%   -0.14%     
==========================================
  Files          67       68       +1     
  Lines        4747     4827      +80     
  Branches     1169     1197      +28     
==========================================
+ Hits         4243     4308      +65     
- Misses        414      422       +8     
- Partials       90       97       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdb9696 sdb9696 requested a review from rytilahti April 26, 2024 10:35
@sdb9696

sdb9696 commented Apr 26, 2024

Copy link
Copy Markdown
Collaborator Author

Closed and replaced with #873

@sdb9696 sdb9696 closed this Apr 26, 2024
@sdb9696 sdb9696 deleted the add_fan_interface branch May 3, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.