Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Simplify mac address handling#162

Merged
kirichkov merged 1 commit into
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:fix/kl430_macrytilahti/python-kasa:fix/kl430_macCopy head branch name to clipboard
May 12, 2021
Merged

Simplify mac address handling#162
kirichkov merged 1 commit into
python-kasa:masterpython-kasa/python-kasa:masterfrom
rytilahti:fix/kl430_macrytilahti/python-kasa:fix/kl430_macCopy head branch name to clipboard

Conversation

@rytilahti

Copy link
Copy Markdown
Member

Fixes #159

@codecov-commenter

codecov-commenter commented May 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #162 (bf9f977) into master (28a902c) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   74.42%   74.44%   +0.02%     
==========================================
  Files          11       11              
  Lines        1220     1221       +1     
  Branches      177      177              
==========================================
+ Hits          908      909       +1     
  Misses        279      279              
  Partials       33       33              
Impacted Files Coverage 螖
kasa/smartdevice.py 82.40% <66.66%> (+0.05%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 28a902c...bf9f977. Read the comment docs.

@kirichkov kirichkov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kirichkov kirichkov merged commit c7a47ea into python-kasa:master May 12, 2021
@rytilahti rytilahti deleted the fix/kl430_mac branch May 12, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KL430 causing "non-hexadecimal number found in fromhex() arg at position 2" error in smartdevice.py

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.