Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Decompressor uses inexistent dictionary API #215

Copy link
Copy link
@illia-v

Description

@illia-v
Issue body actions

While I was working on #207, I noticed that the decompressor class allows passing a custom dictionary, but the functionality is not working because lib.BrotliDecoderSetCustomDictionary was dropped since v1.0.9.0.

if dictionary:
self._dictionary = ffi.new("uint8_t []", dictionary)
self._dictionary_size = len(dictionary)
lib.BrotliDecoderSetCustomDictionary(
self._decoder,
self._dictionary_size,
self._dictionary
)

AttributeError: cffi library '_brotlicffi' has no function, constant or global variable named 'BrotliDecoderSetCustomDictionary'. Did you mean: 'BrotliDecoderAttachDictionary'?

It may be possible to use BrotliDecoderAttachDictionary instead of BrotliDecoderSetCustomDictionary.

This functionality has been broken for a few releases, so I hope it doesn't block releasing v1.2.0.0.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.