Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Draft: Add merge request to merge train #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
p-varma wants to merge 3 commits into from
Closed

Draft: Add merge request to merge train #2552

p-varma wants to merge 3 commits into from

Conversation

@p-varma
Copy link

@p-varma p-varma commented Apr 20, 2023

MR is in Draft state
Yet to write the testcases.

Changes

Documentation and testing

Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated:

@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (f310764) 96.21% compared to head (ecaa566) 96.07%.
Report is 149 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
- Coverage   96.21%   96.07%   -0.14%     
==========================================
  Files          87       87              
  Lines        5700     5726      +26     
==========================================
+ Hits         5484     5501      +17     
- Misses        216      225       +9
Flag Coverage Δ
api_func_v4 82.37% <66.66%> (-0.08%) ⬇️
cli_func_v4 83.02% <66.66%> (-0.09%) ⬇️
unit 87.77% <66.66%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gitlab/v4/objects/projects.py 98.86% <100.00%> (+<0.01%) ⬆️
gitlab/v4/objects/merge_trains.py 74.28% <64.00%> (-25.72%) ⬇️

robinson96
robinson96 reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@robinson96 robinson96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My team is already using this branch for our workflow, so excited to have this piece of the puzzle.

FWIW - at least in current versions of Gitlab, we are seeing issues with the merge train actually being merged in if the SHA is not specified as part of the request. May consider having the SHA be required at this layer so others are able to dodge the pain.

@github-actions
Copy link

github-actions bot commented Feb 13, 2024

This PR was closed because it has been marked stale for 15 days with no activity. If this PR is still valid, please re-open.

@github-actions github-actions bot closed this Feb 13, 2024
@nejch nejch mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@robinson96 robinson96 robinson96 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

need info stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@p-varma @robinson96 @JohnVillalovos @prashantv-cb
Morty Proxy This is a proxified and sanitized view of the page, visit original site.