Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Allow blank token in config #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
so0k wants to merge 1 commit into from
Closed

Allow blank token in config #185

so0k wants to merge 1 commit into from

Conversation

@so0k
Copy link

@so0k so0k commented Nov 21, 2016

Using a config with http_username/http_password only (no token) did not work...

The changes in this pull request allow usage of gitlab-cli with the following config:

[global]
default = example
ssl_verify = true
timeout = 5

[example]
url = https://gitlab.example.com
http_username = root
http_password = mypassword

@so0k
Copy link
Author

so0k commented Nov 21, 2016

should probably test if http_username & http_password are blank and throw auth error

@gpocentek
Copy link
Contributor

gpocentek commented Nov 27, 2016

Thank you for this patch.

I didn't know it was possible to disabled token authentication. Could you tell me where this should be configured on the gitlab side?

Also the travis test fails, this probably means something unexpected now happens with token authentication. Could you check?

@gpocentek
Copy link
Contributor

gpocentek commented Sep 10, 2017

I'm closing this PR since it didn't get an answer or an update in months. Feel free to provide a new one.

@gpocentek gpocentek closed this Sep 10, 2017
@so0k
Copy link
Author

so0k commented Sep 10, 2017

It's ok, works in my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@so0k @gpocentek
Morty Proxy This is a proxified and sanitized view of the page, visit original site.