Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@nejch
Copy link
Member

@nejch nejch commented Jan 14, 2022

This is all @sattlerc's work, with added tests based on the project transfer tests.

@nejch nejch marked this pull request as ready for review January 14, 2022 01:13
@codecov-commenter
Copy link

Codecov Report

Merging #1837 (fd29c0a) into main (0788fe6) will increase coverage by 4.45%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
+ Coverage   87.80%   92.26%   +4.45%     
==========================================
  Files          77       77              
  Lines        4839     4849      +10     
==========================================
+ Hits         4249     4474     +225     
+ Misses        590      375     -215     
Flag Coverage Δ
cli_func_v4 81.29% <50.00%> (-0.07%) ⬇️
py_func_v4 80.30% <100.00%> (+0.04%) ⬆️
unit 83.29% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/exceptions.py 100.00% <100.00%> (+0.70%) ⬆️
gitlab/v4/objects/groups.py 88.65% <100.00%> (+0.68%) ⬆️
gitlab/v4/objects/commits.py 94.73% <0.00%> (+1.31%) ⬆️
gitlab/v4/objects/packages.py 96.29% <0.00%> (+1.85%) ⬆️
gitlab/v4/objects/issues.py 89.02% <0.00%> (+2.43%) ⬆️
gitlab/mixins.py 91.50% <0.00%> (+2.50%) ⬆️
gitlab/v4/objects/events.py 98.73% <0.00%> (+2.53%) ⬆️
gitlab/cli.py 98.36% <0.00%> (+3.27%) ⬆️
gitlab/v4/objects/releases.py 100.00% <0.00%> (+4.00%) ⬆️
... and 21 more

@@ -1,2 +1,2 @@
GITLAB_IMAGE=gitlab/gitlab-ce
GITLAB_TAG=14.5.2-ce.0
GITLAB_TAG=14.6.2-ce.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sneaky... 😁

@JohnVillalovos JohnVillalovos merged commit 57bb67a into main Jan 14, 2022
@JohnVillalovos JohnVillalovos deleted the feat/transfer-group branch January 14, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.