Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@nejch
Copy link
Member

@nejch nejch commented Jan 13, 2022

Needed to bring things in line with #1807.

transfer_project was very confusing already as the direction of transfer can differ depending on the endpoint, see other PR for discussion.

@nejch nejch force-pushed the feat/transfer-method branch from 693c270 to 1e24c85 Compare January 13, 2022 23:32
gitlab/v4/objects/projects.py Outdated Show resolved Hide resolved
gitlab/v4/objects/projects.py Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1833 (1e24c85) into main (da30753) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
+ Coverage   92.20%   92.25%   +0.04%     
==========================================
  Files          77       77              
  Lines        4834     4839       +5     
==========================================
+ Hits         4457     4464       +7     
+ Misses        377      375       -2     
Flag Coverage Δ
cli_func_v4 81.35% <66.66%> (-0.03%) ⬇️
py_func_v4 80.26% <100.00%> (+0.06%) ⬆️
unit 83.26% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/projects.py 88.09% <100.00%> (+0.89%) ⬆️

Co-authored-by: John Villalovos <john@sodarock.com>
@nejch nejch marked this pull request as ready for review January 13, 2022 23:50
Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@JohnVillalovos JohnVillalovos merged commit 0788fe6 into main Jan 14, 2022
@JohnVillalovos JohnVillalovos deleted the feat/transfer-method branch January 14, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.