Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(api): services: add missing lazy parameter #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nejch merged 1 commit into from
Jan 13, 2022
Merged

fix(api): services: add missing lazy parameter #1829

nejch merged 1 commit into from
Jan 13, 2022
+20 −1

Conversation

@JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Jan 13, 2022

Commit 8da0b75 added the lazy
parameter to the services get() method but missed then using the
lazy parameter when it called super(...).get(...)

Closes: #1828

@JohnVillalovos
fix(api): services: add missing lazy parameter
888f332 
Commit 8da0b75 added the `lazy`
parameter to the services `get()` method but missed then using the
`lazy` parameter when it called `super(...).get(...)`

Closes: #1828
@JohnVillalovos JohnVillalovos mentioned this pull request Jan 13, 2022
Closed
nejch
nejch approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick action @JohnVillalovos! Seems like we have two scopes in the commit message somehow 😁 but all good I think

@nejch nejch merged commit 824151c into main Jan 13, 2022
@nejch nejch deleted the jlvillal/lazy_service branch January 13, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nejch nejch nejch approved these changes

@max-wittig max-wittig Awaiting requested review from max-wittig

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lazy creation of service object still fails with 404 error

3 participants

@JohnVillalovos @nejch
Morty Proxy This is a proxified and sanitized view of the page, visit original site.