fix(utils): prevent negative sleep time in rate limit retry #3308
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0c3667 to
6470802
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3308 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 98 98
Lines 6052 6052
=======================================
Hits 5793 5793
Misses 259 259
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
@JohnVillalovos: Could you take a look at this change? Please |
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where negative sleep times could occur when processing rate limit responses with RateLimit-Reset headers that contain timestamps in the past.
Key changes:
- Added
max(0, ...)guard to prevent negative wait time calculation whenRateLimit-Resettimestamp is in the past
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6470802 to
895874f
Compare
JohnVillalovos
approved these changes
Dec 11, 2025
Member
JohnVillalovos
left a comment
There was a problem hiding this comment.
Thanks @AlexandreEXFO
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolution of the error that sometimes occurs: "Error: sleep length must be non-negative"
Documentation and testing
Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated: