Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 840572e

Browse filesBrowse files
JohnVillalovosnejch
authored andcommitted
chore: correct type-hint for job.trace()
Closes: #2808
1 parent 62fa271 commit 840572e
Copy full SHA for 840572e

File tree

Expand file treeCollapse file tree

1 file changed

+2
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-5
lines changed
Open diff view settings
Collapse file

‎gitlab/v4/objects/jobs.py‎

Copy file name to clipboardExpand all lines: gitlab/v4/objects/jobs.py
+2-5Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def trace(
209209
*,
210210
iterator: bool = False,
211211
**kwargs: Any,
212-
) -> Dict[str, Any]:
212+
) -> Optional[Union[bytes, Iterator[Any]]]:
213213
"""Get the job trace.
214214
215215
Args:
@@ -236,12 +236,9 @@ def trace(
236236
)
237237
if TYPE_CHECKING:
238238
assert isinstance(result, requests.Response)
239-
return_value = utils.response_content(
239+
return utils.response_content(
240240
result, streamed, action, chunk_size, iterator=iterator
241241
)
242-
if TYPE_CHECKING:
243-
assert isinstance(return_value, dict)
244-
return return_value
245242

246243

247244
class ProjectJobManager(RetrieveMixin, RESTManager):

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.