Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 5b7d00d

Browse filesBrowse files
JohnVillalovosJohnVillalovos
committed
test(functional): fix GitLab configuration to support pagination
When pagination occurs python-gitlab uses the URL provided by the GitLab server to use for the next request. We had previously set the GitLab server configuraiton to say its URL was `http://gitlab.test` which is not in DNS. Set the hostname in the URL to `http://127.0.0.1:8080` which is the correct URL for the GitLab server to be accessed while doing functional tests. Closes: #1877
1 parent 5e19694 commit 5b7d00d
Copy full SHA for 5b7d00d

File tree

Expand file treeCollapse file tree

3 files changed

+4
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+4
-4
lines changed
Open diff view settings
Collapse file

‎tests/functional/api/test_gitlab.py‎

Copy file name to clipboardExpand all lines: tests/functional/api/test_gitlab.py
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,13 @@ def test_template_dockerfile(gl):
8181

8282

8383
def test_template_gitignore(gl):
84-
assert gl.gitignores.list()
84+
assert gl.gitignores.list(all=True)
8585
gitignore = gl.gitignores.get("Node")
8686
assert gitignore.content is not None
8787

8888

8989
def test_template_gitlabciyml(gl):
90-
assert gl.gitlabciymls.list()
90+
assert gl.gitlabciymls.list(all=True)
9191
gitlabciyml = gl.gitlabciymls.get("Nodejs")
9292
assert gitlabciyml.content is not None
9393

Collapse file

‎tests/functional/api/test_projects.py‎

Copy file name to clipboardExpand all lines: tests/functional/api/test_projects.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ def test_project_protected_branches(project):
244244

245245

246246
def test_project_remote_mirrors(project):
247-
mirror_url = "http://gitlab.test/root/mirror.git"
247+
mirror_url = "https://gitlab.example.com/root/mirror.git"
248248

249249
mirror = project.remote_mirrors.create({"url": mirror_url})
250250
assert mirror.url == mirror_url
Collapse file

‎tests/functional/fixtures/docker-compose.yml‎

Copy file name to clipboardExpand all lines: tests/functional/fixtures/docker-compose.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ services:
1414
GITLAB_ROOT_PASSWORD: 5iveL!fe
1515
GITLAB_SHARED_RUNNERS_REGISTRATION_TOKEN: registration-token
1616
GITLAB_OMNIBUS_CONFIG: |
17-
external_url 'http://gitlab.test'
17+
external_url 'http://127.0.0.1:8080'
1818
registry['enable'] = false
1919
nginx['redirect_http_to_https'] = false
2020
nginx['listen_port'] = 80

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.