Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3fb4486

Browse filesBrowse files
authored
Merge pull request #1862 from thomasgl-orange/cli-fix-timeout
fix(cli): make 'timeout', 'per_page' and 'page' type explicit
2 parents 30117a3 + d493a5e commit 3fb4486
Copy full SHA for 3fb4486

File tree

Expand file treeCollapse file tree

2 files changed

+4
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-2
lines changed
Open diff view settings
Collapse file

‎gitlab/cli.py‎

Copy file name to clipboardExpand all lines: gitlab/cli.py
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ def _get_base_parser(add_help: bool = True) -> argparse.ArgumentParser:
181181
"[env var: GITLAB_TIMEOUT]"
182182
),
183183
required=False,
184+
type=int,
184185
default=os.getenv("GITLAB_TIMEOUT"),
185186
)
186187
parser.add_argument(
@@ -196,6 +197,7 @@ def _get_base_parser(add_help: bool = True) -> argparse.ArgumentParser:
196197
"[env var: GITLAB_PER_PAGE]"
197198
),
198199
required=False,
200+
type=int,
199201
default=os.getenv("GITLAB_PER_PAGE"),
200202
)
201203
parser.add_argument(
Collapse file

‎gitlab/v4/cli.py‎

Copy file name to clipboardExpand all lines: gitlab/v4/cli.py
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,8 @@ def _populate_sub_parser_by_class(
218218
f"--{x.replace('_', '-')}", required=False
219219
)
220220

221-
sub_parser_action.add_argument("--page", required=False)
222-
sub_parser_action.add_argument("--per-page", required=False)
221+
sub_parser_action.add_argument("--page", required=False, type=int)
222+
sub_parser_action.add_argument("--per-page", required=False, type=int)
223223
sub_parser_action.add_argument("--all", required=False, action="store_true")
224224

225225
if action_name == "delete":

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.