Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Collect test coverage results for collectors too #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shortdudey123 wants to merge 2 commits into
base: master
Choose a base branch
Loading
from
Open

Collect test coverage results for collectors too #627

shortdudey123 wants to merge 2 commits into from

Conversation

@shortdudey123
Copy link
Member

@shortdudey123 shortdudey123 commented Mar 30, 2017

No description provided.

@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage remained the same at 24.964% when pulling 58a0047 on expand_coverage_settings into 1c0935b on master.

@shortdudey123
Copy link
Member Author

shortdudey123 commented Mar 30, 2017

Looks like each collector also needs __init__.py to be considered by coverage

Only importable files (ones at the root of the tree, or in directories with a __init__.py file) will be considered. ~ http://coverage.readthedocs.io/en/coverage-4.3.4/source.html#execution

$ find src -name __init__.py
src/diamond/__init__.py
src/diamond/handler/__init__.py
src/diamond/utils/__init__.py
$

@shortdudey123 shortdudey123 force-pushed the expand_coverage_settings branch 2 times, most recently from c78c2fb to b91efb7 Compare April 6, 2017 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shortdudey123 @coveralls
Morty Proxy This is a proxified and sanitized view of the page, visit original site.