This repository was archived by the owner on Apr 15, 2024. It is now read-only.
put token to header if present #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@cablehead I tried to fix tests but there is still this issue: I have seen it also it other PRs. Could you help me please? |
|
I took a very similar approach in my pull request (#205). I guess I should have checked here before submitting mine. |
636f367 to
a91daae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
according to latest consul documentation for authentication: https://www.consul.io/api/index.html#authentication, consul client should insert token to the header when sending requests to agent.
This is my implementation, hopefully it'll help somebody.
Thank you for your great work.
Dominik