This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Fix deregister service and add tests #174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Author
|
Workaround is: This will override the "bad" deregister method and use put instead of get. |
Merged
harpratap
approved these changes
Nov 30, 2017
This was referenced Jan 9, 2018
alvaroaleman
added a commit
to alvaroaleman/ansible
that referenced
this pull request
Jan 14, 2018
Upstream pr in the python-consul library: python-consul/python-consul#174 This is based on work from https://github.com/bobh Fixes ansible#34628
ansibot
pushed a commit
to ansible/ansible
that referenced
this pull request
Mar 6, 2018
* Fix consul module service deregistration Upstream pr in the python-consul library: python-consul/python-consul#174 This is based on work from https://github.com/bobh Fixes #34628 * Pass ACL token when deregistering consul service
gundalow
pushed a commit
to gundalow/ansible
that referenced
this pull request
Mar 6, 2018
* Fix consul module service deregistration Upstream pr in the python-consul library: python-consul/python-consul#174 This is based on work from https://github.com/bobh Fixes ansible#34628 * Pass ACL token when deregistering consul service (cherry picked from commit c9cb001)
gundalow
added a commit
to ansible/ansible
that referenced
this pull request
Mar 6, 2018
* Fix consul module service deregistration Upstream pr in the python-consul library: python-consul/python-consul#174 This is based on work from https://github.com/bobh Fixes #34628 * Pass ACL token when deregistering consul service (cherry picked from commit c9cb001)
abadger
pushed a commit
to ansible/ansible
that referenced
this pull request
Mar 29, 2018
* Fix consul module service deregistration Upstream pr in the python-consul library: python-consul/python-consul#174 This is based on work from https://github.com/bobh Fixes #34628 * Pass ACL token when deregistering consul service (cherry picked from commit c9cb001)
Collaborator
|
#182 is finally merged. Please re-open if this is still an issue. Thanks @matusvalo! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service deregister needs to be PUT instead of GET.
Also added tests for the Service object, using the API definition as comparisons.