Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add a missing comma to __all__ #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2021
Merged

Conversation

BvB93
Copy link
Contributor

@BvB93 BvB93 commented May 4, 2021

A comma is currently missing between "DefaultDict" and "OrderedDict",
thus concatenating both names into the non-existent "DefaultDictOrderedDict".

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Maybe worth a patch release? cc @JelleZijlstra

@JelleZijlstra
Copy link
Member

Well that's embarrassing. I'm hoping we'll also get Required/NotRequired in soon, so let's give it a few more days for a release.

@JelleZijlstra JelleZijlstra merged commit c4191ac into python:master May 4, 2021
@BvB93 BvB93 deleted the __all__ branch May 4, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.