Bump test dependencies; improve pycln config
#9197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR to my typeshed fork showing that pycln still works fine in CI with the new config setup: AlexWaygood#7 |
JelleZijlstra
approved these changes
Nov 14, 2022
|
@AlexWaygood I think you missed a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump mypy to 0.991
Bump pytype to 2022.11.10
Bump pycln to 2.1.2
Enable the new
disable_all_dunder_policyflag for pycln.This flag means that pycln treats
__init__.py(i)files just like normal.py(i)files. By default, pycln is much more cautious when removing imports from__init__.py(i)files due to the fact that many projects use "redundant" imports in__init__.pyfiles for implicit reexports. But it doesn't make sense for pycln to apply the same level of caution to__init__.pyifiles in stubs, where all imports are "private to the stub" except imports using theimport foo as fooidiom. So it makes sense to enable this flag for typeshed.Put all pycln config in the
pyproject.tomlfile instead of hardcoding it into the.pre-commit-config.yamlfile.