stripe: test clocks resource #9026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbdchd
commented
Oct 29, 2022
|
|
||
| @classmethod | ||
| def advance(cls, idempotency_key: str | None = None, **params: Any) -> Self: ... | ||
| def advance(self, idempotency_key: str | None = None, **params: Any) -> Self: ... |
There was a problem hiding this comment.
the api supports:
stripe.test_helpers.TestClock.advance(frozen_time=frozen_time)and
clock = stripe.test_helpers.TestClock.create(frozen_time=frozen_time)
clock.advance(frozen_time=frozen_time)
This comment has been minimized.
This comment has been minimized.
| OBJECT_NAME: Literal["test_helpers.test_clock"] | ||
|
|
||
| @classmethod | ||
| def advance(cls: type[Self], idempotency_key: str | None = ..., **params: Any) -> Self: ... |
There was a problem hiding this comment.
This weird thing Stripe does where the method is both an instance method and a class method is confusing, but what you currently have is invalid.
I think putting only a classmethod would produce correct types, because classmethods can also be called on instances. So I suggest removing the last line.
There was a problem hiding this comment.
ah thank you! removing the instance method worked like a charm!
AlexWaygood
reviewed
Oct 29, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
hmm having some issues getting the stub test to ignore test clocks: |
| @@ -1,5 +1,6 @@ | ||
| # The following methods have custom classmethod decorators | ||
| stripe\..*\.delete | ||
| stripe\..*PaymentIntent\.confirm | ||
| stripe\.api_resources\..*\.SearchableAPIResource\.search # Not defined on the actual class in v3, but expected to exist. | ||
| stripe\.api_resources\..*\.SearchableAPIResource\.search_auto_paging_iter # Not defined on the actual class in v3, but expected to exist. | ||
| stripe\..*TestClock\.advance |
There was a problem hiding this comment.
Do we need the wildcard? Seems like stripe.api_resources.test_helpers.test_clock.TestClock.advance would work.
sbdchd
commented
Oct 29, 2022
sbdchd
commented
Oct 29, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based off: https://github.com/stripe/stripe-python/blob/16812ae9ff5b78d8f103c09da461e5569890d05f/stripe/api_resources/test_helpers/test_clock.py
and https://stripe.com/docs/api/test_clocks/advance?lang=python