Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add tests for MutableMapping.update() #14104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025
Merged

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented May 20, 2025

From #14099

This comment has been minimized.

@srittau srittau marked this pull request as draft May 20, 2025 09:08
@srittau
Copy link
Collaborator Author

srittau commented May 20, 2025

It's interesting that pyright infers a literal here, instead of going with an int. This of course fails due to the invariance of dict and MutableMapping.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau marked this pull request as ready for review May 20, 2025 09:39
@srittau srittau changed the title Add a test for MutableMapping.update() Add tests for MutableMapping.update() May 20, 2025
@srittau srittau merged commit 66cf58e into python:main May 20, 2025
64 checks passed
@srittau srittau deleted the mutable-mapping-test branch May 20, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.