Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add heapq types #14098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 19, 2025
Merged

Add heapq types #14098

merged 11 commits into from
May 19, 2025

Conversation

StanFromIreland
Copy link
Contributor

I'm not sure if I've done everything required, I have not contributed here before.

Added types for some functions I added.

This comment has been minimized.

stdlib/_heapq.pyi Outdated Show resolved Hide resolved
stdlib/heapq.pyi Outdated Show resolved Hide resolved
@StanFromIreland StanFromIreland requested a review from srittau May 19, 2025 14:07

This comment has been minimized.

This comment has been minimized.

stdlib/heapq.pyi Outdated Show resolved Hide resolved

This comment has been minimized.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one more change below then this is good to go.

stdlib/_heapq.pyi Outdated Show resolved Hide resolved
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit db4a25c into python:main May 19, 2025
64 checks passed
@StanFromIreland StanFromIreland deleted the heapqtypes branch May 19, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.