Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Bugfix to don't ignore add-ons #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Bugfix to don't ignore add-ons #1941

merged 2 commits into from
Dec 16, 2021

Conversation

berinhard
Copy link
Contributor

This PR addresses the following feedback about the sponsorships module:

Add-on items did not work when being added to a package for Meta

Not confirmed, but report of add-on items being selected and displayed while
applying and confirming, but not associated with the resulting sponsorship application.

The bug has happening due to a missing logic to SponsorshiptBenefitsForm.get_benefits method. This method is used to get all the benefits that should be used during the new sponsorship creation. But it wasn't returning the add ons benefits, even though the data was present in form.cleaned_data.

This PR fixes this logic and also updates the views tests to be more accurate about the benefits creation.

@berinhard berinhard requested a review from ewdurbin December 16, 2021 18:43
@ewdurbin
Copy link
Member

Thanks @berinhard.

@ewdurbin ewdurbin merged commit b2f1a91 into main Dec 16, 2021
@ewdurbin ewdurbin deleted the bugfix/ignoring-add-ons branch December 16, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.