Bugfix to don't ignore add-ons #1941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following feedback about the sponsorships module:
The bug has happening due to a missing logic to
SponsorshiptBenefitsForm.get_benefits
method. This method is used to get all the benefits that should be used during the new sponsorship creation. But it wasn't returning the add ons benefits, even though the data was present inform.cleaned_data
.This PR fixes this logic and also updates the views tests to be more accurate about the benefits creation.