Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enhancement: Sanitize release names to require string #2724

Copy link
Copy link
Open
@JacobCoffee

Description

@JacobCoffee
Issue body actions

Is your feature request related to a problem? Please describe.

When creating a new release to test #2717, I thought the PR was bad because it was possible to create a release named just 3.20, causing the downloads/windows/ page to crash because it lacked a None check in the PR for release version.

Describe the solution you'd like

It'd be nice to just give a little error message in the admin form submission via:

def clean(self):
  super().clean()
  if not re.match(r'^Python\s[\d.]+$', self.name):
      raise ValidationError({
          'name': 'Name must be in the format "Python X.Y.Z" (e.g., "Python 3.9.0")'
      })

to get:
Image

Basic Example

No response

Describe alternatives you've considered

No response

Drawbacks and Impact

No response

Additional context

No response

Metadata

Metadata

Assignees

Labels

app/downloadsRelates to the downloads appRelates to the downloads appenhancementThis is an improvement to existing code or configurationThis is an improvement to existing code or configuration

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.