Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Translate string.rst:777 to 786 #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2024
Merged

Translate string.rst:777 to 786 #717

merged 2 commits into from
Jan 4, 2024

Conversation

proudofsimin
Copy link
Contributor

Hi, All
Please review. Thank you.

ken71301
ken71301 reviewed Nov 25, 2023
View reviewed changes
library/string.po Outdated Show resolved Hide resolved
rockleona
rockleona reviewed Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Part 1

library/string.po Outdated Show resolved Hide resolved
ken71301
ken71301 reviewed Nov 25, 2023
View reviewed changes
Copy link
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用詞與空格需修正

library/string.po Outdated Show resolved Hide resolved
@ken71301 ken71301 changed the base branch from 3.12 to event-1125 November 25, 2023 08:45
ken71301
ken71301 reviewed Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

仍有部分翻譯錯誤

library/string.po Outdated Show resolved Hide resolved
library/string.po Outdated Show resolved Hide resolved
library/string.po Outdated Show resolved Hide resolved
library/string.po Outdated Show resolved Hide resolved
@ken71301 ken71301 assigned ken71301 and proudofsimin and unassigned ken71301 Dec 5, 2023
@mattwang44
Copy link
Collaborator

rebase

mattwang44
mattwang44 reviewed Dec 6, 2023
View reviewed changes
library/string.po Outdated Show resolved Hide resolved
@rockleona
Copy link
Collaborator

@proudofsimin rebase 需要協助的話都可以跟我說喔
也可以到 Discord 私訊我

@proudofsimin
Copy link
Contributor Author

@proudofsimin rebase 需要協助的話都可以跟我說喔
也可以到 Discord 私訊我

Sry for the late reply. I’m pretty occupied these days. I’m not sure what that means but will try to work on it next week. Many thanks!

@proudofsimin
Copy link
Contributor Author

proudofsimin commented Dec 17, 2023 •
edited
Loading

Hi,
I googled what rebase means, but I'm not sure if there's anything else I should've done other than regular git check-in. Please let me know if I have use the command correctly. Thank you.

@mattwang44
Copy link
Collaborator

mattwang44 commented Dec 18, 2023 •
edited
Loading

Hi @proudofsimin
If you're referring to the rebase comment I left last time, it means I've done a git rebase (doc and visualization) for the branch of this PR. Whenever your branch has any conflict with the target branch (like now), you'll need to resolve with git rebase ... or git merge ... command. We prefer the former as the commit history would be more readable, which eases the pain for reviewers. You can resolve the conflict on the GitHub UI, but it runs a git merge ... command under the hood.

Feel free to pin us on the Discord server if you have any questions!

@mattwang44 mattwang44 requested a review from ken71301 January 3, 2024 01:12
@mattwang44
Copy link
Collaborator

mattwang44 commented Jan 3, 2024 •
edited
Loading

嗨 @proudofsimin
最近要 wrap up 我們 11 月活動的所有 PR 了，想請問你有空來處理這個 PR 嗎？
還是我能否幫你來修正剩下未完成的部分呢？

ken71301
ken71301 reviewed Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the sentence in L:1053 and we are good to go.

@proudofsimin
Copy link
Contributor Author

嗨 @proudofsimin 最近要 wrap up 我們 11 月活動的所有 PR 了，想請問你有空來處理這個 PR 嗎？ 還是我能否幫你來修正剩下未完成的部分呢？

好，我好感動謝謝！！我自己在local端試了好幾次修不好我的environment弄不上去...非常感謝

@mattwang44
Copy link
Collaborator

@proudofsimin 好呀，我就先處理這個 PR，如果是對於 git or github 操作上遇到問題的話都歡迎在 discord 上找我們討論歐！

@mattwang44 mattwang44 merged commit 0533ee6 into python:event-1125 Jan 4, 2024
@proudofsimin
Copy link
Contributor Author

@proudofsimin 好呀，我就先處理這個 PR，如果是對於 git or github 操作上遇到問題的話都歡迎在 discord 上找我們討論歐！

好的超級感謝，我其實之前沒用過discord所以一直都不敢發言...造成您們的困擾了非常不好意思ＱＱ

@mattwang44
Copy link
Collaborator

@proudofsimin 沒關係的 沒有造成困擾～
如果不敢公開發言的話也可以考慮私訊我 (my id: mattwang44)，不用怕麻煩到我（只是我比較忙的話就會比較晚回而已XD）

mattwang44 added a commit that referenced this pull request Jan 26, 2024
@proudofsimin @mattwang44
Translate string.rst:777 to 786 (#717)
f234e38 
* Translate rst777:786.

* fix(library/string): refine translation

---------

Co-authored-by: Matt Wang <mattwang44@gmail.com>
mattwang44 added a commit that referenced this pull request Jan 27, 2024
@proudofsimin @mattwang44
Translate string.rst:777 to 786 (#717)
2e590b9 
* Translate rst777:786.

* fix(library/string): refine translation

---------

Co-authored-by: Matt Wang <mattwang44@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwang44 mattwang44 mattwang44 left review comments

@ken71301 ken71301 ken71301 left review comments

@rockleona rockleona Awaiting requested review from rockleona

Assignees

@proudofsimin proudofsimin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@proudofsimin @mattwang44 @rockleona @ken71301
Morty Proxy This is a proxified and sanitized view of the page, visit original site.