-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Add flag to raise error if match statement does not match exaustively #19144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Don-Burns
wants to merge
23
commits into
python:master
Choose a base branch
from
Don-Burns:feat/exhaustive-match
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
02796d9
Add check for exhaustive match statements
Don-Burns 3aaa98b
Add flag for exhaustive match statements
Don-Burns 6b613f5
Update docs for exhaustive match statements
Don-Burns 3341b4b
Add flag to mypy_primer
Don-Burns a186cc8
Revert "Add flag to mypy_primer"
Don-Burns ec55c81
Move tests to 3.10 file so only run on >=3.10
Don-Burns 8ce5b6a
Rename flag to better follow other flags
Don-Burns 3581ec9
Fix doc gen error
Don-Burns 0f9ed6a
Set default True for CI run, will revert before merge
Don-Burns 62e4089
Revert "Set default True for CI run, will revert before merge"
Don-Burns abf7e98
Add explicit error code - change [misc] -> [exhaustive-match]
Don-Burns 6a525f7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7dc7c01
Add missed docs
Don-Burns 3ab9848
fixup! Add missed docs
Don-Burns 1a3e359
fixup! fixup! Add missed docs
Don-Burns fecd37d
Change to error code only for exhaustive match
Don-Burns 525924f
Merge doc literal paragraph
Don-Burns f798b43
Empty commit to trigger CI
Don-Burns 9b200ac
Apply suggestions to remove whitespace from tests
Don-Burns 681a327
fixup! Apply suggestions to remove whitespace from tests
Don-Burns d219871
Add test for more complex narrowing use case
Don-Burns 914bff4
fixup! Add test for more complex narrowing use case
Don-Burns 4cc25fe
Merge branch 'master' into feat/exhaustive-match
Don-Burns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge doc literal paragraph
- Loading branch information
commit 525924f0e29939d401b90561d03d1ea10837bf72
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be expanded instead of adding a new paragraph:
(not sure that's better than your current approach now that I write it out, actually)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right here 👍
Changed to 1 paragraph