Add config key to extend config files #19135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasier
commented
May 23, 2025
mypy/config_parser.py
Outdated
|
|
||
| if "mypy" not in parser: | ||
| if filename or os.path.basename(file_read) not in defaults.SHARED_CONFIG_NAMES: | ||
| print(f"{file_read}: No [mypy] section in config file", file=stderr) | ||
| else: | ||
| section = parser["mypy"] | ||
|
|
||
| extend = parser["mypy"].pop("extend", None) |
There was a problem hiding this comment.
[info] I thought about adding extend to the toml/ini templates above, but I was not sure of the way they might be used elsewhere, so it felt like doing something ad-hoc would be more suitable here. Happy to change it if there's another preferred way.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9620
First and foremost, thanks to everyone that's working on maintaining and extending this project! 🙇 This is my first contribution here, hopefully a useful one.
I have been working in a monorepo project for a while and we have been trying to consolidate some of our configurations. I was coming from doing this with
ruff, but I couldn't find a way formypyto combine config files, when I found this comment. Seeing there was already an open discussion for it and a pointer in that direction, I thought I'd give it a go at updating themypybehaviour.I understand this might require a broader discussion regarding how this config extension/merge should happen, so I know this PR might not be the preferred option. Happy to contribute to the discussion however I can, but I thought it might be good to re-open the discussion with a (potential) solution in this PR.